fix: preserve "//" in redirect URLs with empty authority#2484
Open
vatsalpatel wants to merge 2 commits intosupabase:masterfrom
Open
fix: preserve "//" in redirect URLs with empty authority#2484vatsalpatel wants to merge 2 commits intosupabase:masterfrom
vatsalpatel wants to merge 2 commits intosupabase:masterfrom
Conversation
Go's net/url normalizes "scheme://" with empty authority to "scheme:" on String(), breaking iOS/Android custom-scheme deep links like "myapp://" emitted as "myapp:?code=...". Adds utilities.PreserveEmptyAuthority and applies it in all redirect URL builders in internal/api/verify.go and oauthserver/authorize.go. Closes supabase#2423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Custom-scheme PKCE redirect URIs with empty authority get the
//stripped when serialized. Go'snet/urlnormalizesscheme://with no host down toscheme:onString():iOS/Android clients registered for the
scheme://form don't matchscheme:?..., so native Sign in with Apple / Google deep links via PKCE fail silently. Affects every redirect URL builder that round-trips throughurl.Parse→ mutate →u.String():internal/api/verify.go—prepErrorRedirectURL,prepRedirectURL,prepPKCERedirectURLinternal/api/oauthserver/authorize.go—buildSuccessRedirectURL,buildErrorRedirectURLWhat is the new behavior?
Adds
utilities.PreserveEmptyAuthoritywhich detects when the original input usedscheme://with empty authority and restores the//thatnet/urldrops. Applied at all five build sites above.Leaves already-correct inputs untouched (including intentional
scheme:without slashes, and any URL with a host or path).Test plan
go test -run TestPreserveEmptyAuthority ./internal/utilities— table-driven coverage for empty authority, host+path, triple-slash, existing query, fragment, reverse-DNS schemes, plainscheme:(unchanged), andhttps://(unchanged).go vet ./...cleanCloses #2423