feat(apple): expose given_name and family_name in user metadata#2498
Open
elisealix22 wants to merge 1 commit intosupabase:masterfrom
Open
feat(apple): expose given_name and family_name in user metadata#2498elisealix22 wants to merge 1 commit intosupabase:masterfrom
elisealix22 wants to merge 1 commit intosupabase:masterfrom
Conversation
Author
|
@fadymak Is it possible to get this in your review pipeline? It would be really helpful to be able to differentiate between first and last name in my app and it appears we already have that data, just need to pipe it thru. Right now I only have access to full name thru SIWA OAuth and I believe this will fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Missing given and family names from Apple. Only full name is passed through to user metadata currently.
What is the new behavior?
given_nameandfamily_namewill be included in the user metadata when using SIWA OAuth. We already had the values, but were concatenating it to one string. Thegiven_nameandfamily_namematch existing json values in provider.go:auth/internal/api/provider/provider.go
Lines 96 to 97 in bb521e4
Additional context
This will be more reliable and correct than trying to full names down into first names and last names.