test(stack): wait on podman container removal instead of its rotating event log

[jgoux]

TL;DR

stops the Podman sweep integration test from timing out with The next owner did not sweep orphans.

whats broken?

the test waits for each swept container's remove event from podman events --since …. On CI, Podman logs events to a shared file that it rotates when it reaches its size limit. A reader that hasn't polled an event yet when the log rotates skips it, so the wait never completes and the test hits its 1 minute timeout. Parallel Podman test files fill that log quickly, so this happens occasionally in the Podman integration job.

now fixed by:

• on Podman, the helper waits on the container itself with podman wait --condition removing --ignore, which also returns for a container that is already gone. Docker keeps its event stream, which is not affected.
• the database stop test's helper reads Podman's exit code with podman wait <container> instead of its died event, which the same rotation can drop.
• the timeout message names the waits that are still pending, so any remaining failure points at its cause.

ref:

• seen on: fix(stack): recreate containers whose published host port was taken before start #7081 (merge queue) and https://github.com/supabase/cli/actions/runs/37703640927

[github-actions]

🤖 AI Review

Reconciled both review inputs and confirmed one minor test-reliability finding. Podman's wait condition does not reliably establish completed removal. Runtime tests could not run in the read-only environment.

Findings

Severity	Location	Category	Sources	Claim
🟡 MINOR	packages/stack/tests/engine-events.ts:31	test-reliability	claude	Waiting for Podman's removing state does not guarantee that the container is absent before the helper succeeds. On CI's Podman 4.9, disappearance between status polls can also produce a wait error despite --ignore, causing the sweep test to fail during successful cleanup.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0

---

Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.