refactor: drop axios from iceberg rest catalog client#1042
Open
ferhatelmas wants to merge 1 commit intomasterfrom
Open
refactor: drop axios from iceberg rest catalog client#1042ferhatelmas wants to merge 1 commit intomasterfrom
ferhatelmas wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the Iceberg REST catalog client to remove Axios usage in favor of native fetch, while adding a unified request pipeline (URL building, JSONBigint serialization/parsing, auth) and new unit tests covering request behavior.
Changes:
- Replaced Axios client/interceptors with a
fetch-basedrequest()helper (supports query params, JSONBigint, auth, and timeout). - Updated SigV4 and bearer auth adapters to work with the new request config shape.
- Added unit tests validating URL joining, signing behavior, headers, timeouts, and JSONBigint handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/storage/protocols/iceberg/catalog/rest-catalog-client.ts | Introduces fetch request pipeline, query param handling, timeout support, and updates auth integration. |
| src/storage/protocols/iceberg/catalog/rest-catalog-client.test.ts | Adds unit tests for URL composition, signing, headers, timeouts, JSONBigint, and error translation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24835712470Coverage increased (+1.0%) to 70.992%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/axios-rest-catalog
branch
from
b485efe to
215184b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TylerHillery
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
What is the current behavior?
axios is used in iceberg rest catalog client.
What is the new behavior?
axios is replaced with native fetch.
Additional context
Drop any usage.
Add more test coverage.
Some more resilience via timeout and keep-alive.