fix: drop axios from image renderer#1056
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the image renderer to drop Axios/axios-retry in favor of native fetch, while adding targeted unit coverage for retry/timeout/abort behavior.
Changes:
- Replaced Axios-based imgproxy client with a native
fetchimplementation including retry + timeout handling. - Updated route tests to reflect the new client request options (no
responseType: 'stream'). - Added a new
ImageRendererunit test suite covering metadata mapping, retries, aborts, and timeout edge-cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/storage/renderer/image.ts | Replaces Axios client with fetch + retry/timeout logic and updates error/stream handling. |
| src/test/render-routes.test.ts | Updates mocks/assertions for the new renderer client options shape. |
| src/storage/renderer/image.test.ts | Adds unit coverage for the new fetch client behavior (retries/timeouts/aborts/stream stalling). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24906764211Coverage increased (+0.3%) to 71.905%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
from
3deb1e5 to
fdd3586
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
from
fdd3586 to
5f2c629
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
from
5f2c629 to
1762947
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
2 times, most recently
from
b5236ba to
da0e2d0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
from
da0e2d0 to
86e0df3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
2 times, most recently
from
e433643 to
8c0237d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/image-renderer-axios
branch
from
8c0237d to
4039b3d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What kind of change does this PR introduce?
refactor
What is the current behavior?
Axios and its retry package are used in image renderer.
What is the new behavior?
They are both replaced by native fetch.
Additional context
Add coverage.