fix: allow PUT tenant to clear database_pool_url and database_pool_mode#1069
Open
oniani1 wants to merge 1 commit intosupabase:masterfrom
Open
fix: allow PUT tenant to clear database_pool_url and database_pool_mode#1069oniani1 wants to merge 1 commit intosupabase:masterfrom
oniani1 wants to merge 1 commit intosupabase:masterfrom
Conversation
Coverage Report for CI Build 25131948326Coverage increased (+0.3%) to 72.266%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PUT
/tenants/:idhandler used truthy guards ondatabasePoolUrlanddatabasePoolMode, so a request withnullwould skip the assignment and the merge upsert left the existing column unchanged. The schema declares both fieldsnullable: true, and the PATCH handler at lines 396-401 already does the three-way check.This switches both checks to
!== undefinedand treats explicitnullas a clear, mirroring PATCH.tenantDBInterfacewas widened to allowstring | nullon the two columns so the assignment typechecks.admin-tenants.test.tsadds a case that PUTs a tenant with both pool fields populated, verifies the encrypted/string values land in the DB, then PUTs again withnullfor both and asserts the columns are nowNULL. Verified locally againstmultitenant_dbrunning in Docker; the case fails on master and passes with the fix.Closes #1068