Correct '--rm' argument placement in docker run shell script#27
Conversation
- Fixes issue supercharge#26 where the '--rm' flag was applied after the image argument. - Adds a new CI workflow 'container-remove-flag.yml' to test this scenario.
|
@DhavalGojiya Hey Dhaval, thank you for the pull request. Very nice! Out of interest: has AI generated the changes? (I’m asking because of all the added comments with emojis) |
Nope, I added everything myself. I am using "act" to test everything. Actually, I've also created a similar GitHub Action for Apache Solr; you can check it in my repo. |
Please let me know if anything is missing or needs to be updated in PR. |
|
Thank you Dhaval! |
Welcome 🙌 |
This PR fixes issue #26 where the
--rmflag was incorrectly placed after the Docker image argument.--rmis applied before the image.container-remove-flag.yml) to test theredis-remove-container: truescenario across Redis versions5, 6, 7.This ensures containers start correctly and are automatically removed when requested.