feat(layout-resolved): carry SDT container key chain through resolved layout#3755
Draft
caio-pizzol wants to merge 3 commits into
Draft
feat(layout-resolved): carry SDT container key chain through resolved layout#3755caio-pizzol wants to merge 3 commits into
caio-pizzol wants to merge 3 commits into
Conversation
… layout resolveFragmentSdtContainerKey now returns a key for image and drawing fragments (was null), and a new resolveFragmentSdtContainerKeys derives the full outer-to-inner chain from attrs.sdtContainers, exposed as ResolvedPaintItem.sdtContainerKeys. The chain is folded into deriveBlockVersion so paint reuse invalidates when a block's content-control nesting changes even if its nearest sdt is unchanged. Adds a cache-bust unit test. Refs #3745
…188-fu2-resolve-sdt-chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of #3752, stacked on #3753. Resolved layout now carries the SDT container key chain so the painter (FU3) can group and draw nested content-control chrome.
resolveFragmentSdtContainerKeynow returns a key for image and drawing fragments (it returned null before), so the boundary pass can keep a control's image/drawing fragments in the same run instead of treating them as gaps.resolveFragmentSdtContainerKeysderives the full outer-to-inner chain fromattrs.sdtContainers(falling back to the single nearest key), exposed asResolvedPaintItem.sdtContainerKeys.deriveBlockVersion, so paint reuse invalidates when a block's content-control nesting changes even if its nearestsdtis unchanged. Added a cache-bust unit test for that case.The actual container chrome on image/drawing fragments and the depth-aware nested boxes land in FU3; editor lock enforcement is unchanged (PM-tree based).
Stacked on #3753 - retarget to
mainafter it merges. Refs #3745.Verified: type-checked locally (contracts
tscbuild +layout-resolvedDTS build both clean). Unit tests run in CI. Draft until #3753 lands and CI is green.