fix(vscode-ext): prevent autosave from opening a Save File dialog on every edit#3781
Open
claudiusararu wants to merge 1 commit into
Open
fix(vscode-ext): prevent autosave from opening a Save File dialog on every edit#3781claudiusararu wants to merge 1 commit into
claudiusararu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #3768. Editing any
.docxin the SuperDoc VS Code extension pops a browser "Save File" dialog on essentially every edit (the ~1s debounced autosave and Cmd/Ctrl+S both trigger it), which makes real editing unusable.Root cause
The webview autosave calls
editor.export({ format: 'docx' }). SuperDoc'sexport()defaultstriggerDownload: true, and for a single docx blob that path callscreateDownload(...)→window.showSaveFilePicker, opening the dialog. (formatis also not a recognizedexport()option — the correct key isexportType.)Fix
Pass
triggerDownload: false(and the correctexportType: ['docx']) soexport()returns the Blob directly — exactly what theblob.arrayBuffer()→postMessagesave path consumes. No dialog; silent autosave-to-disk keeps working.