feat: Improved keyboard behaviour on Android#397
feat: Improved keyboard behaviour on Android#397LizaPolishchuk wants to merge 6 commits intosuperlistapp:mainfrom
Conversation
Added show and hide menu callbacks;
|
Hide keyboard on Android when menu shown, also added parameter shouldReopenKeyboard to reopen it, when menu hidden; 2024-07-23.15.39.48.mp4 |
|
Thank you for the PR. I like the idea in generall and this basically replicates what already happens on iOS, however I don't like that this requires unfocusing. It would worth figuring out if we can hide the keyboard without unfocus (same behavior as iOS). |
|
@knopp Hello! Thanks for review, sure we achieve the same behaviour using native methods:
but in this case - we need to check if the keyboard was visible before we hide it to understand do we need to reopen it. But for that need to add package [https://pub.dev/packages/flutter_keyboard_visibility] . I am not sure that you will approve adding some additional libraries to your package |
|
Instead of adding a dependency that is only used on one platform, I'd probably go with implementing a method channel call handler in We only need a very small part of the plugin functionality and only one one platform, that's why I don't want to introduce a dependency for this. |
626d6e1 to
027293a
Compare
dfd929c to
7ad9a97
Compare
# Conflicts: # super_clipboard/example/pubspec.lock # super_context_menu/example/pubspec.lock # super_context_menu/example/pubspec.yaml # super_context_menu/lib/src/desktop.dart # super_context_menu/lib/src/menu.dart # super_context_menu/lib/super_context_menu.dart # super_context_menu/pubspec.yaml
No description provided.