Skip to content

Fix test paths and refresh lockfile#9

Merged
MaheshtheDev merged 2 commits into
supermemoryai:mainfrom
williamclay8:codex/fix-test-paths-lockfile
May 22, 2026
Merged

Fix test paths and refresh lockfile#9
MaheshtheDev merged 2 commits into
supermemoryai:mainfrom
williamclay8:codex/fix-test-paths-lockfile

Conversation

@williamclay8
Copy link
Copy Markdown

Summary

  • use fileURLToPath for test script paths so tests pass from directories with spaces
  • refresh package-lock metadata to match package.json and remove stale dependency entries

Verification

  • npm test

Direct push to upstream was blocked for williamclay8, so this PR comes from the fork.

Copy link
Copy Markdown

@vorflux vorflux Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Test path fixes (test/unit.mjs, test/e2e-battle-test.mjs) — correct. Using fileURLToPath instead of .pathname is the right fix for paths with spaces.

package-lock.json dep removal — expected and correct. The current package.json on main only lists @iarna/toml and supermemory as runtime deps. @modelcontextprotocol/sdk and zod are already gone from package.json — the lockfile was stale from a prior version. Regenerating it produces exactly this result. Running npm install yourself would give the same diff.

Version mismatch — one issue: the lockfile in this PR sets version 1.0.5 but package.json on main is already at 1.0.6. The branch was generated against a slightly older commit. Should be rebased onto main + npm install re-run before merging so the versions are consistent.

@ved015
Copy link
Copy Markdown
Member

ved015 commented May 21, 2026

@williamclay8 thank you for your contribution

@ved015
Copy link
Copy Markdown
Member

ved015 commented May 21, 2026

LGTM

@ved015
Copy link
Copy Markdown
Member

ved015 commented May 21, 2026

@MaheshtheDev pls merge this

@MaheshtheDev MaheshtheDev merged commit b20d6d0 into supermemoryai:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants