DONT merge#1194
Conversation
fetch-graph-data returned raw DocumentsApiResponse as structuredContent, which the widget cannot dispatch on, rendering "Received unrecognized response from server" despite the call succeeding. It now returns a proper graph ViewMessage so the widget renders the memory graph.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | b356798 | Commit Preview URL Branch Preview URL |
Jul 03 2026, 03:23 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
supermemory-mcp | b356798 | Jul 03 2026, 03:22 PM |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude finished @ved015's task in 1m 30s —— View job Review Complete
Overview: This PR fixes Issues found: None — this looks good to ship. The fix correctly follows the established pattern used in Score: 10/10 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: This PR fixes fetch-graph-data to return a proper ViewMessage instead of raw DocumentsApiResponse, enabling the widget to correctly render the memory graph.
Issues found: None — this looks good to ship.
The fix correctly follows the established pattern used in memory-graph.ts (lines 46-51). The ViewMessage type for "graph" view is properly satisfied with all required fields: view, documents, totalCount, and optional containerTag. The text content is also improved to be human-readable instead of raw JSON.
Score: 10/10
![vorflux[bot]](https://avatars.githubusercontent.com/in/2483280?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
Reviewed — found 1 issue(s). This change updates fetch-graph-data to return a graph ViewMessage in structuredContent so the MCP widget can route it correctly, but the diff also changes the structured response contract. I reviewed the changed apps/mcp/src/server/tools/fetch-graph-data.ts path for regressions in caller-visible data shape.
Findings
apps/mcp/src/server/tools/fetch-graph-data.ts
structuredContentwas converted to a graphViewMessagebut no longer includespagination, breaking callers and tests that rely onstructuredContent.pagination.
Verdict
|
|
||
| // structuredContent must be a ViewMessage — the widget dispatches on | ||
| // `view` and renders anything else as an "unrecognized response" error. | ||
| const sc: ViewMessage = { |
There was a problem hiding this comment.
structuredContent now becomes a ViewMessage, but this drops the existing pagination object even though fetch-graph-data still accepts page/limit and apps/mcp/e2e/graph.test.ts still asserts res.structuredContent.pagination.limit === 5. This breaks the structured pagination contract for callers and will likely fail the graph E2E case when API_KEY is present. Please keep the graph ViewMessage shape for widget dispatch, but preserve pagination in structuredContent too, for example by extending the graph view message with pagination: data.pagination and updating the shared type.
TestingStatic validation was completed for the MCP server change in Commands run: git diff --stat origin/fix/mcp-widget-error-display...origin/fix/mcp-fetch-graph-data-view
git diff --unified=80 origin/fix/mcp-widget-error-display...origin/fix/mcp-fetch-graph-data-view -- apps/mcp/src/server/tools/fetch-graph-data.ts
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/src/server/tools/fetch-graph-data.ts
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/src/shared/types.ts
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/src/widget/App.tsx
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/src/widget/hooks/useViewState.ts
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/src/server/tools/memory-graph.ts
git show origin/fix/mcp-fetch-graph-data-view:apps/mcp/e2e/graph.test.tsResult: Verdict
|
ishaanxgupta
changed the base branch from
fix/mcp-widget-error-display
to
graphite-base/1194
ishaanxgupta
changed the title
2 participants
No description provided.