Skip to content

feat(web): Company Brain proactiveness (automations) settings#1207

Merged
graphite-app[bot] merged 1 commit into
mainfrom
mahesh/company-brain-proactiveness-ui
Jul 7, 2026
Merged

feat(web): Company Brain proactiveness (automations) settings#1207
graphite-app[bot] merged 1 commit into
mainfrom
mahesh/company-brain-proactiveness-ui

Conversation

@MaheshtheDev

Copy link
Copy Markdown
Member

Adds the Proactiveness settings tab for Company Brain channel/DM automations.

  • Accordion list of automations — collapsed rows with an instant enable toggle + Run now, expand to edit.
  • Two-column editor: prompt (left) / deliver-to channel or DM, frequency, day, time (right), with local-timezone-aware cron.
  • Preset gallery (connection-first, category-diverse) for empty state + a New-automation menu.
  • DM delivery option with a tooltip explaining channel visibility + personal-connection fallback.
  • Profile-menu entry (gated on Company Brain).

Pairs with the API automations work: supermemoryai/mono#2480.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 97888ce Jul 07 2026, 09:22 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 97888ce Commit Preview URL

Branch Preview URL
Jul 07 2026, 09:23 PM

@MaheshtheDev MaheshtheDev marked this pull request as ready for review July 7, 2026 01:03
@claude

claude Bot commented Jul 7, 2026

Copy link
Copy Markdown

Claude finished @MaheshtheDev's task in 1m 50s —— View job


Review Complete

  • Load review tools
  • Get PR diff and existing review comments
  • Read changed files and analyze for bugs/security issues
  • Submit review

Summary: Reviewed the Company Brain proactiveness (automations) settings UI. The code is clean — no bugs, security issues, or logic errors found.

Key areas verified:

  • Cron timezone conversion logic correctly handles local↔UTC including day-of-week shifts
  • API error handling is consistent with proper 403 and JSON parse fallbacks
  • Input validation before saves (title, channel requirements)
  • React Query caching with org-scoped keys

Score: 10/10 — Good to ship.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a Proactiveness settings tab for Company Brain channel/DM automations with cron scheduling, preset templates, and timezone-aware time conversion.

Issues found: None — this looks good to ship.

Reviewed areas:

  • Cron conversion logic (toUtcCron/fromUtcCron): Correctly handles local↔UTC conversion including day-of-week shifts when crossing midnight. Uses Date objects for proper timezone math.
  • API error handling: Consistent pattern across all mutations with proper 403 handling and JSON parse fallbacks.
  • Input validation: Title and channel requirements validated before save; empty prompts fall back to default.
  • State management: React Query with proper cache keys including org?.id for org-scoped data; useRef for stable draft key generation.
  • Authorization: Admin check is case-insensitive as expected.

Score: 10/10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31b9b5539f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/components/settings/settings-content.tsx
Comment thread apps/web/components/settings/company-brain-automations.tsx

@vorflux vorflux Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Reviewed — found 1 issue(s). This PR adds the Company Brain Proactiveness settings UI, including the new automations page, settings navigation entry points, and analytics event wiring. The review focused on the changed UI/API integration paths and found that the feature is enabled before the required backend routes are available.

Findings

apps/web/components/settings/company-brain-automations.tsx

  1. The new settings page calls the /brain/automations API, but the corresponding backend routes are not present/deployed, so list/channel loads and all save/delete/run actions fail.

Verdict

⚠️ Changes requested. The UI should not ship enabled until the matching backend endpoints are available or the tab is feature-gated with visible load-error handling.


Review with Vorflux

Comment thread apps/web/components/settings/company-brain-automations.tsx
@vorflux

vorflux Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Testing

Manual browser/UI verification was completed with local scaffolding because no saved browser session was available and the production backend does not expose the new /brain/automations endpoints. The UI flow rendered and behaved as expected under scaffolding, but the real API-backed feature is blocked because the production endpoints return 404.

Commands run:

curl -sS -X GET https://api.supermemory.ai/brain/automations/
curl -sS -X GET https://api.supermemory.ai/brain/automations/channels
curl -sS -X GET https://api.supermemory.ai/brain/automations/fake-id
curl -sS -X POST https://api.supermemory.ai/brain/automations/fake-id/run-now
curl -sS -X GET https://api.supermemory.ai/brain/mcp-connections/

Result:

GET /brain/automations/ -> 404 Not Found
GET /brain/automations/channels -> 404 Not Found
GET /brain/automations/fake-id -> 404 Not Found
POST /brain/automations/fake-id/run-now -> 404 Not Found
GET /brain/mcp-connections/ -> 401 {"error":"unauthorized"}

Evidence artifacts:

Verdict

⚠️ Issues found. The scaffolded UI path works, but the production backend routes required by the feature are missing, so this should not ship enabled until those endpoints are implemented or deployed.


Attached Images and Videos

pr1207-profile-menu-proactiveness.png

pr1207-proactiveness-reopened.png

pr1207-proactiveness-blank-form.png

pr1207-proactiveness-validation.png

pr1207-proactiveness-delivery-select.png

pr1207-proactiveness-saved-row.png

pr1207-proactiveness-run-now.png

pr1207-proactiveness-toggled-off.png

pr1207-proactiveness-edit-open.png

pr1207-proactiveness-after-delete.png

pr1207-proactiveness-non-company-gated.png

pr1207-profile-menu-non-company.png

pr1207-proactiveness-mobile.png

pr1207-proactiveness-mobile-fixed.png

🎥 View recording: pr1207-company-brain-proactiveness-flow.webm

@graphite-app

graphite-app Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merge activity

Adds the **Proactiveness** settings tab for Company Brain channel/DM automations.

- Accordion list of automations — collapsed rows with an instant enable toggle + **Run now**, expand to edit.
- Two-column editor: prompt (left) / deliver-to channel or DM, frequency, day, time (right), with local-timezone-aware cron.
- Preset gallery (connection-first, category-diverse) for empty state + a New-automation menu.
- DM delivery option with a tooltip explaining channel visibility + personal-connection fallback.
- Profile-menu entry (gated on Company Brain).

Pairs with the API automations work: **supermemoryai/mono#2480**.
@graphite-app graphite-app Bot force-pushed the mahesh/company-brain-proactiveness-ui branch from 31b9b55 to 97888ce Compare July 7, 2026 21:20
@graphite-app graphite-app Bot merged commit 97888ce into main Jul 7, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants