Skip to content

fix(web): keep personal connector action visible - #1573

Draft
Dhravya wants to merge 1 commit into
mainfrom
vorflux/fix-personal-connector-action
Draft

fix(web): keep personal connector action visible#1573
Dhravya wants to merge 1 commit into
mainfrom
vorflux/fix-personal-connector-action

Conversation

@Dhravya

@Dhravya Dhravya commented Aug 20, 2026

Copy link
Copy Markdown
Member

Restores the personal connector action in the compact Installed tile for non-admin users whose workspace already has the connector installed.

Changes

  • Show Connect my account when the workspace connection is active but the current user has not connected personally.
  • Keep workspace administration controls restricted to admins.
  • Retain the personal disconnect action when the current user is already connected.

Testing

  • bunx biome check apps/web/components/settings/company-brain-connections.tsx
  • git diff --check origin/main...HEAD
  • Reviewed the installed-tile state branches for admin, personal-only, and workspace-only connection states.
  • Repository-wide apps/web TypeScript checking remains blocked by existing unrelated errors; none reference the touched component.

This is a follow-up to the review on merged PR #1461.


Session Details


Note

Low Risk
Small settings-menu UX fix for existing connect/disconnect flows; no auth, API, or permission-model changes.

Overview
Non-admin users can now connect a personal account from the compact Installed tile when the workspace already has that connector.

Previously that state showed a disabled “Managed by workspace admins” item. It now offers Connect my account. Personal disconnect stays when the user is already connected; the leftover empty state is labeled Not connected. Admin workspace controls are unchanged.

Reviewed by Cursor Bugbot for commit 69d95ab. Bugbot is set up for automated code reviews on this repo. Configure here.

@Dhravya
Dhravya marked this pull request as draft August 20, 2026 23:01

Dhravya commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

Claude finished @Dhravya's task in 1m 0s —— View job


Review Summary

Overview: Allows non-admin users to connect their personal account to a connector when the workspace has already connected it at the org level.

Analysis: The fix adds a missing intermediate state in the dropdown menu logic:

  • Before: Non-admins saw a disabled "Managed by workspace admins" when they weren't personally connected, blocking them from connecting even when the org had the connector set up
  • After: When orgConnected is true but userConnected is false, non-admins now see "Connect my account" — matching the behavior already available to admins (lines 955-966)

The implementation correctly:

  • Uses connect(entry, false) to connect the user's personal account (not the org)
  • Mirrors the exact pattern used in the admin dropdown options
  • Falls back to a disabled "Not connected" only when neither user nor org has connected

Issues found: None — this looks good to ship.

Score: 10/10


|

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 69d95ab Aug 20 2026, 11:02 PM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 69d95ab Commit Preview URL

Branch Preview URL
Aug 20 2026, 11:04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant