Skip to content

fix(raycast): only offer http(s) URLs from server-controlled metadata #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sravanjangam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(raycast): only offer http(s) URLs from server-controlled metadata #1585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/raycast-extension/src/search-memories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,18 @@ const extractContent = (memory: SearchResult) => {

const extractUrl = (memory: SearchResult) => {
if (memory.metadata?.url && typeof memory.metadata.url === "string") {
return memory.metadata.url
const url = memory.metadata.url
// Server-controlled value: only offer http(s). Without a scheme
// allowlist, a crafted memory could hand javascript:, file:, or
// arbitrary app-handler URLs to the OS opener.
try {
const parsed = new URL(url)
if (parsed.protocol === "https:" || parsed.protocol === "http:") {
return url
}
} catch {
return null
}
}
return null
}
Expand Down