Skip to content

Obsidian Connector [dont merge]#988

Open
sreedharsreeram wants to merge 8 commits into
mainfrom
feat/obsidian-connector
Open

Obsidian Connector [dont merge]#988
sreedharsreeram wants to merge 8 commits into
mainfrom
feat/obsidian-connector

Conversation

@sreedharsreeram
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 22, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 696861f May 22 2026, 01:33 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 22, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 696861f Commit Preview URL

Branch Preview URL
May 22 2026, 01:34 AM

@sreedharsreeram sreedharsreeram changed the title Obsidian Connector Obsidian Connector [dont merge] May 22, 2026
@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

Claude finished @sreedharsreeram's task in 1m 55s —— View job


Reviewed PR #988: Obsidian Connector

  • Fetching PR diff
  • Analyzing code for bugs and security issues
  • Checking existing review comments
  • Submitting review

Summary: Reviewed all 15 changed files (876 additions). The Obsidian plugin implementation is solid with proper error handling, batching, and debouncing. No bugs or security issues found. Code is ready to ship.

Note: The Cloudflare deployment failures appear to be unrelated to this PR's changes — they may be caused by missing backend API routes (/v3/connections/obsidian) which would need to be added separately.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: Next.js is vulnerable to RCE in React flight protocol

CVE: GHSA-9qr9-h5gf-34mp Next.js is vulnerable to RCE in React flight protocol (CRITICAL)

Affected versions: >= 14.3.0-canary.77 < 15.0.5; >= 15.1.0-canary.0 < 15.1.9; >= 15.2.0-canary.0 < 15.2.6; >= 15.3.0-canary.0 < 15.3.6; >= 15.4.0-canary.0 < 15.4.8; >= 15.5.0-canary.0 < 15.5.7; >= 16.0.0-canary.0 < 16.0.7

Patched version: 16.0.7

From: packages/tools/test/chatapp/package.jsonnpm/next@16.0.0

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/next@16.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds an Obsidian plugin to sync vault notes to Supermemory, with supporting UI changes in the web app.

Issues found: None — this looks good to ship.

The plugin implementation is well-structured:

  • API client with proper error handling for auth failures and rate limiting
  • Sync engine with batching (50 notes/batch) and debouncing (3s) to avoid overwhelming the API
  • Proper handling of file create/modify/delete/rename events
  • Settings UI for API key, sync mode (all vault vs. selected folders), and container tags

The web app changes correctly add Obsidian as a connector option with appropriate handling (shows installation instructions instead of OAuth flow).

Score: 9/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant