Skip to content

enable timeline memory selection#990

Open
ishaanxgupta wants to merge 1 commit into
mainfrom
ishaa/dev5
Open

enable timeline memory selection#990
ishaanxgupta wants to merge 1 commit into
mainfrom
ishaa/dev5

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented May 22, 2026

Summary

  • Wire selection mode state and toggle handlers into the memories timeline view
  • Show checkboxes for timeline cards when selection mode is active
  • Make single timeline cards toggle selection instead of opening documents
  • Add group-level selection for collapsed timeline groups
  • Show individual checkboxes for expanded group items

before:
image

after:
image
image

@graphite-app graphite-app Bot requested a review from Dhravya May 22, 2026 07:05
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 9a410f6 May 22 2026, 07:05 AM

@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

Claude finished @ishaanxgupta's task in 1m 20s —— View job


Reviewing PR #990: enable timeline memory selection

  • Analyze PR diff and changes
  • Review for bugs, security issues, and logic errors
  • Check surrounding code context
  • Submit review findings

Review submitted. No bugs, security issues, or logic errors found. The implementation adds selection mode support with proper defensive null checks, correct group selection semantics, and good accessibility attributes.

Score: 10/10 — Ready to ship.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 9a410f6 Commit Preview URL

Branch Preview URL
May 22 2026, 07:06 AM

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds selection mode support to the timeline view, allowing users to select individual cards and groups of documents with proper handling for temporary IDs.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Defensive null checks added to groupDocuments (replacing ! assertions with ?? [] and flatMap filtering)
  • isTemporaryId correctly excludes temp documents from selection
  • Group selection logic properly handles select-all/deselect-all semantics
  • Accessibility attributes (aria-pressed, aria-expanded, aria-label) are properly applied
  • Selection state is correctly passed through from parent component

Score: 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant