4.15.2

[yusuftor]

4.15.2

Enhancements

• Improves Apple Search Ads attribution capture rate.
• Filters out the all-zeros IDFA sentinel (returned when App Tracking Transparency is denied) so it no longer pollutes the idfa attribute on attribution payloads.

Fixes

• Changes the Superscript spm package repo source to a new lightweight repo meaning that the download of the package is way faster.

Greptile Summary

This PR releases version 4.15.2 with two attribution improvements: filtering out the all-zeros IDFA sentinel (returned when ATT is denied), and a substantial overhaul of the Apple Search Ads attribution retry system to improve capture rate.

• Dependency swap: Superscript-iOS replaced by the lighter superscript-ios-next (v1.0.14) across all Package.resolved, Package.swift, project.yml, and Xcode project files.
• IDFA filter: AttributionFetcher now discards the 00000000-… UUID returned when ATT is not authorized, preventing it from appearing as a real advertiser ID in attribution payloads.
• Attribution retry overhaul: AttributionPoster gains a cross-launch attempt budget (8 tries, 24h window), an in-session backoff for transient Apple SDK errors (2/6/15s), a generation-stamp single-flight guard, cooperative cancellation for reset races, and a migration (v4→v5) that moves the token sentinel from user-specific to app-scoped storage so it survives user logout without re-fetching.

Confidence Score: 4/5

Safe to merge; the attribution logic is well-guarded and the storage migration has a no-op path for users without legacy data.

The attribution poster rewrite is large but thoroughly commented and backed by new tests covering the key guard conditions. The one notable style issue is zeroAdvertisingIdentifier being typed as UUID? rather than UUID, meaning the sentinel filter relies on optional equality — harmless in practice since the literal is always valid, but worth tightening. No data-loss, auth, or crash risks were identified.

Sources/SuperwallKit/Analytics/Attribution/AttributionFetcher.swift — the zeroAdvertisingIdentifier optional type; Sources/SuperwallKit/Analytics/Attribution/AttributionPoster.swift — the redesigned retry/cancellation logic is the most complex part of this PR and deserves a careful read.

Important Files Changed

Filename	Overview
Sources/SuperwallKit/Analytics/Attribution/AttributionPoster.swift	Major rewrite adding cross-launch retry budget (8 attempts, 24h window), single-flight generation stamps, in-session token-fetch backoff, and cancellation support; logic is well-structured and commented with appropriate cooperative-cancellation checks throughout.
Sources/SuperwallKit/Analytics/Attribution/AttributionFetcher.swift	Adds IDFA zero-sentinel filter and canProduceAdServicesToken guard; zeroAdvertisingIdentifier is typed UUID? rather than UUID, creating a potentially silent no-op comparison if the optional were nil.
Sources/SuperwallKit/Storage/Cache/CacheKeys.swift	Moves AdServicesTokenStorage from .userSpecificDocuments to .appSpecificDocuments and adds three new app-scoped storage types for retry bookkeeping, unsupported-device sentinel, and cached attribution data; all appropriately scoped.
Sources/SuperwallKit/Storage/Migration/V4Migrator.swift	New migrator that moves the AdServices token sentinel from user-specific to app-specific storage on upgrade, with a safe no-op path when no legacy data exists and a guard against overwriting an already-migrated value.
Sources/SuperwallKit/Storage/Migration/FileManagerMigrator.swift	Adds v5 to DataStoreVersion and wires V4Migrator into the recursive migration chain; existing tests were updated to match the new terminal version.
Sources/SuperwallKit/Superwall.swift	Removes the upfront ASA token call from configure() (replaced by config-subscription-driven triggering in AttributionPoster) and adds cancelInFlight + reapplyCachedAttribution around storage.reset() in the reset path.
Sources/SuperwallKit/Network/Network.swift	Changes sendToken from returning [String: Any] (swallowing errors) to throwing AdServicesResponse, letting the caller handle failures and bump the retry budget.
Tests/SuperwallKitTests/Analytics/Attribution/AdServicesAttributionTests.swift	New test suite covering the main guard conditions (max attempts, retry window expiry, permanently-unsupported sentinel, previously-posted sentinel) plus Codable round-trips and storage round-trips; uses the Swift Testing framework as required.
Tests/SuperwallKitTests/Storage/Migration/FileManagerMigratorTests.swift	Updated end-to-end migration test to assert v5 as the final version, and added three V4→V5 migration scenarios (normal, no legacy data, legacy-vs-new collision).
Sources/SuperwallKit/Analytics/Attribution/AdServicesAttributionAttempts.swift	New Codable/Equatable struct tracking attempt count and first/last attempt dates for cross-launch retry bookkeeping.
Package.swift	Switches the Superscript dependency from Superscript-iOS repo (bloated xcframework) to the lighter superscript-ios-next at version 1.0.14.

Sequence Diagram

sequenceDiagram
    participant SW as Superwall
    participant AP as AttributionPoster
    participant CM as ConfigManager
    participant AF as AttributionFetcher
    participant NW as Network
    participant ST as Storage

    SW->>AP: init() → listenToConfig()
    CM-->>AP: "configState emits (enabled=true)"
    AP->>AP: getAdServicesTokenIfNeeded()
    AP->>ST: get(AdServicesAttributionAttemptsStorage)
    AP->>AP: canStartAttempt() guards
    Note over AP: Already posted? Unsupported? No token env? Config off? Budget/window exceeded?
    AP->>AP: "Task { runAttempt() }"
    AP->>AF: adServicesToken (with 0s/2s/6s/15s backoff)
    AF-->>AP: token or error
    alt Permanent error
        AP->>ST: save(true, AdServicesAttributionUnsupportedStorage)
    else Transient error
        AP->>ST: recordFailedAttempt()
    else Token obtained
        AP->>NW: sendToken(token) throws AdServicesResponse
        NW-->>AP: AdServicesResponse
        AP->>ST: save(token, AdServicesTokenStorage)
        AP->>ST: save(attribution, AdServicesAttributionDataStorage)
        AP->>SW: setUserAttributes(attribution)
    end

    SW->>AP: reset() → cancelInFlight()
    AP->>AP: task.cancel() + ownerGeneration++
    SW->>ST: storage.reset()
    SW->>AP: reapplyCachedAttribution()
    AP->>ST: get(AdServicesAttributionDataStorage)
    AP->>SW: setUserAttributes(cachedAttribution)

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Sources/SuperwallKit/Analytics/Attribution/AttributionFetcher.swift:59
`zeroAdvertisingIdentifier` is declared as `UUID?` because `UUID(uuidString:)` returns an optional. The comparison `identifierValue == Self.zeroAdvertisingIdentifier` uses optional equality: if `zeroAdvertisingIdentifier` were ever nil (impossible for this literal, but the type allows it), the comparison would be `false` and the all-zeros sentinel would silently pass through unfiltered. Using a force-unwrap makes the non-optional intent explicit and removes the optionality from the comparison site.

```suggestion
  // swiftlint:disable:next force_unwrapping
  private static let zeroAdvertisingIdentifier = UUID(uuidString: "00000000-0000-0000-0000-000000000000")!
```

_{Reviews (1): Last reviewed commit: "Merge pull request #470 from superwall/i..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.