Repository navigation
repo hygiene: fix the ansible .gitignore, .PHONY and repoURL scheme - #613
Merged
Merged
Conversation
ansible/.gitignore carried three rules copied from the root file with the ansible/ prefix intact, so inside ansible/ they resolved to ansible/ansible/... and matched nothing. Patterns are relative to the file that contains them. Corrected and verified: git check-ignore -v now names ansible/.gitignore where it previously named the root. No secret was exposed - the root .gitignore has the same lines in the one place that prefix is correct, and was doing the work. The defect is a second layer that looked like protection and provided none, which is worse than no second layer because a reader checking it would stop looking. Makefile: ldap removed from .PHONY; the target went with the ldap-1 VM in July and .PHONY names a missing target without complaint, which is why it survived. make -n help still parses. gitlab-runner.yaml: two repoURL lines used https where thirteen other sources use git@. Argo keys credentials by URL string, so the spellings were two repositories to it, and the https one had no credential - it worked only because the repo is public. All fifteen now match. Normalised toward git@ because that deploy key demonstrably works; the reverse is defensible but a design choice. Also ticks three items that were already true: the sandbox-vm-update comment now explains the deletion rather than pointing at a live file, FETCH_HEAD is not tracked, and TODO-2026-07-14.md does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible/.gitignore carried three rules copied from the root file with the ansible/ prefix intact, so inside ansible/ they resolved to ansible/ansible/... and matched nothing. Patterns are relative to the file that contains them. Corrected and verified: git check-ignore -v now names ansible/.gitignore where it previously named the root.
No secret was exposed - the root .gitignore has the same lines in the one place that prefix is correct, and was doing the work. The defect is a second layer that looked like protection and provided none, which is worse than no second layer because a reader checking it would stop looking.
Makefile: ldap removed from .PHONY; the target went with the ldap-1 VM in July and .PHONY names a missing target without complaint, which is why it survived. make -n help still parses.
gitlab-runner.yaml: two repoURL lines used https where thirteen other sources use git@. Argo keys credentials by URL string, so the spellings were two repositories to it, and the https one had no credential - it worked only because the repo is public. All fifteen now match. Normalised toward git@ because that deploy key demonstrably works; the reverse is defensible but a design choice.
Also ticks three items that were already true: the sandbox-vm-update comment now explains the deletion rather than pointing at a live file, FETCH_HEAD is not tracked, and TODO-2026-07-14.md does not exist.