Fix graceful shutdown support#87
Merged
aryan-25 merged 1 commit intoJun 3, 2026
Merged
Conversation
gjcairo
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In #79, we introduced support for binding to multiple addresses. However, since all bound channels share a single
ServerQuiescingHelper, this means only the first bound server channel supports graceful shutdown. In addition to this, due to the way #79 handles the cleanup of server channels, as soon as one channel finishes, all other channels are immediately shut down. This means that in-flight requests on every other listener are dropped immediately when_servereturns after the first listener finished. Since different channels may complete draining at different times, we should also fix this.Modifications:
ServerQuiescingHelperfor each bound channel.ServerChannelenum to store the associatedServerQuiescingHelper.beginGracefulShutdownmethod to now iterate every listener and initiate shutdown on each._servetask-group to wait for all listeners to finish, and only tear the whole server down on an error.Result:
Graceful shutdown is now supported on every bound channel.