Derive Maven version from git describe#794
Merged
Merged
Conversation
ktoso
changed the title
ktoso
force-pushed
the
release-version-from-tag
branch
3 times, most recently
from
fa20d4e to
1e44dce
Compare
SwiftKitCore and SwiftKitFFM compute their Maven version directly from the current checkout via `git describe --tags --always`. A checkout on an exact SemVer tag (e.g. `0.4.2`) publishes that version; off-tag working trees publish a tag-prefixed identifier such as `0.4.1-52-g8f0d0794`. This replaces the previous hardcoded `1.0-SNAPSHOT` so Maven coordinates always reflect the upstream commit a consumer pinned.
ktoso
force-pushed
the
release-version-from-tag
branch
from
1e44dce to
68af3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftKitCore and SwiftKitFFM compute their Maven version directly from the current checkout via
git describe --tags --always. A checkout on an exact SemVer tag (e.g.0.4.2) publishes that version; off-tag working trees publish a tag-prefixed identifier such as0.4.1-52-g8f0d0794, this replaces the hardcoded1.0-SNAPSHOTwe had before.We'll do -SNAPSHOT once we actually start publishing them nightly though I think...