Interop: send events to fallback event handler if active configuration not present #1439
+92
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjrchen
added
enhancement
stmontgomery
reviewed
Dec 5, 2025
stmontgomery
reviewed
Dec 5, 2025
grynspan
reviewed
Dec 5, 2025
grynspan
reviewed
Dec 5, 2025
grynspan
reviewed
Dec 5, 2025
| } | ||
|
|
||
| // Encode the event as JSON and pass it to the handler. | ||
| let encodeAndInvoke = ABI.CurrentVersion.eventHandler(encodeAsJSONLines: false) { |
Contributor
There was a problem hiding this comment.
You might want to cache this event handler somewhere as there's a bit of runtime overhead to generating it. Remember the fallback event handler can't change after its initial assignment, and will be set by the time an event is generated, so we don't need to worry about it having changed on later calls (i.e. the closure we generate here can permanently capture it.)
jerryjrchen
force-pushed
the
send-fallback-events-for-interop
branch
from
988b54d to
2dd0432
Compare
As part of the strategy for enabling interoperability, unhandled issues can be turned into events and sent to the fallback event handler. Also link against the _TestingInterop framework/library (depending on the platform), which provides a function to lookup the currently installed fallback event handler.
jerryjrchen
force-pushed
the
send-fallback-events-for-interop
branch
from
2dd0432 to
6736ad8
Compare
stmontgomery
added
the
interoperability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create helper to post test events to fallback event handler
As part of the strategy for enabling interoperability, unhandled issues
can be turned into events and sent to the fallback event handler.
Also link against the _TestingInterop framework/library (depending on
the platform), which provides a function to lookup the currently
installed fallback event handler.