Remove macOS installer dependencies#557
Open
cmcgee1024 wants to merge 1 commit into
Open
Conversation
The macOS installer doesn't permit useful integration tests since it doesn't work well in headless CI environments, and also it doesn't permit directory level customization to the install path. This allows bugs to escape that aren't manually tested since the code paths are never covered by the tests. Use the same pkgutil approach as used by the tests, and cases where toolchains directory has been customized in all cases for macOS.
cmcgee1024
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
etcwilde
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS installer doesn't permit useful integration tests since it doesn't work well in headless CI environments, and also it can't do directory level customization to the install path. This allows bugs to escape that aren't manually tested since the code paths are never covered by the tests.
Use the same pkgutil approach as used by the tests, and cases where toolchains directory has been customized in all cases for macOS.