DRAFT: Testing the new Swift-Subprocess behaviors#558
Draft
etcwilde wants to merge 2 commits into
Draft
Conversation
Switching the build to use the main-branch Subprocess to test new APIs.
Migrating everything to the new APIs. The changes are primarily: - Adding the named `executable` argument name to the `Configuration` construction. - Migrating '.standardOutput'/'.standardError' to '.currentStandardOutput'/`.currentStandardError'. - Using the single execution context passed into the closure instead of the separate stderr/stdout streams. - Migrating from 'CollectedResult' to 'ExecutionResult' - `Executable.resolveExecutablePath` is now an async function, adding `await` to calls. Also updated the handling of errors. `unhandledException` was replaced with a `signaled` case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this as-is!
We should not be pointing
swiftlydirectly at the swift-subprocess main branch. Once a new swift-subprocess is tagged, we will point at that instead.There are some changes coming in the newest versions of Swift-Subprocess that we want to test before it is cut. This PR is to make testing the new Swift-Subprocess easier, migrating our use of the APIs to the latest version, and pointing Swiftly at the
mainbranch.