Fix node version diagnostic handling on test harness#328
Merged
kateinoigakukun merged 1 commit intomainfrom Apr 1, 2025
Merged
Fix node version diagnostic handling on test harness#328kateinoigakukun merged 1 commit intomainfrom
kateinoigakukun merged 1 commit intomainfrom
Conversation
The CompileError usually happens during `defaultNodeSetup`, so we should catch it there. Also `process.version` is a string with a `v` prefix, so we should use `process.versions.node`, which doesn't have the prefix instead.
|
Time Change: -11ms (0%) Total Time: 9,947ms View Unchanged
View Baselines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CompileError usually happens during
defaultNodeSetup, so we should catch it there. Alsoprocess.versionis a string with avprefix, so we should useprocess.versions.node, which doesn't have the prefix instead.