Export UnsafeEventLoopYield error type#339
Merged
kateinoigakukun merged 1 commit intomainfrom Apr 9, 2025
Merged
Conversation
Some apps wrap instance.exports and monitor exceptions thrown during execution of Wasm program but `UnsafeEventLoopYield` is not something they want to report, so they need to be able to filter them out. However, they cannot use `UnsafeEventLoopYield` type name because some bundlers can rename it. We should export it to allow them not to depend on the constructor name
|
Time Change: -290ms (3%) Total Time: 9,618ms
View Unchanged
View Baselines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some apps wrap instance.exports and monitor
exceptions thrown during execution of Wasm program but
UnsafeEventLoopYieldis not something theywant to report, so they need to be able to filter them out. However, they cannot use
UnsafeEventLoopYieldtype name because some bundlers can rename it.We should export it to allow them not to depend on the constructor name