Fix some Embedded Swift issues in JavaScriptEventLoop#344
Merged
kateinoigakukun merged 2 commits intomainfrom Apr 16, 2025
Merged
Fix some Embedded Swift issues in JavaScriptEventLoop#344kateinoigakukun merged 2 commits intomainfrom
JavaScriptEventLoop#344kateinoigakukun merged 2 commits intomainfrom
Conversation
This change fixes some of the issues that appear when building this library with Embedded Swift. It adds missing concurrency imports and avoids use of throwing tasks that are not supported in Embedded Swift. Standard Swift's `Result` type is used instead to express error throwing.
MaxDesiatov
changed the title
JavaScriptEventLoop
| /// | ||
| /// - Note: Calling this function does not switch from the caller's isolation domain. | ||
| public func value(isolation: isolated (any Actor)? = #isolation) async throws -> JSValue { | ||
| try await withUnsafeThrowingContinuation(isolation: isolation) { [self] continuation in |
Member
There was a problem hiding this comment.
We need a typed-throws version of withContinuation 😔
kateinoigakukun
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes some of the issues that appear when building this library with Embedded Swift. It adds missing concurrency imports and avoids use of throwing tasks that are not supported in Embedded Swift. Standard Swift's
Resulttype is used instead to express error throwing.