BridgeJS: Unify JS function calling convention code emission#494
Merged
BridgeJS: Unify JS function calling convention code emission#494
Conversation
kateinoigakukun
force-pushed
the
yt/abi-refactor
branch
from
4f4d909 to
6c1fa5e
Compare
kateinoigakukun
force-pushed
the
yt/abi-refactor
branch
from
6c1fa5e to
289584b
Compare
kateinoigakukun
force-pushed
the
yt/abi-refactor
branch
from
289584b to
da70302
Compare
krodak
approved these changes
Jan 14, 2026
Member
krodak
left a comment
krodak
left a comment
There was a problem hiding this comment.
Nicely simplified interface and intrinsics, hopefully this will make TS -> Swift extensions easier 👌🏻 Thanks for refactor around EnumDeclSyntax 🙇🏻♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for being a big bang change 🙇
This PR unifies code generation of a call to JS function done in ExportSwift into
ImportTS.CallJSEmissiontype (renamed fromImportedThunkBuilder).This change particularly refactors closure and
@JS protocolcode gen in ExportSwift, where calling JS interface from Swift.