BridgeJS: support closure types in imported JS APIs#524
Merged
Conversation
Enable closure parameter/return types for imported JS interfaces and emit the required closure glue from BridgeJSTool.
e37e6d1 to
3286279
Compare
3286279 to
1e4389d
Compare
Add runtime import fixtures and tests for passing Swift closures into JS and receiving JS functions back as Swift closures.
1e4389d to
cef2d6f
Compare
krodak
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported JS interfaces should be able to accept/return callbacks as Swift closures, matching the export-side ergonomics.