BridgeJS: Use let for non-mutated __bjs_self in generated toJSObject()#531
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Jan 27, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Jan 27, 2026
b2e3752 to
9365f89
Compare
9365f89 to
d3c6d53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Aims to remove following warning from
toJSObject()method.Since
toJSObject()borrowsself, the local copy exists to givebridgeJSLowerReturn()something to consume. That copy is never mutated, just consumed, hence we can uselet.