fix: Functions with @JS were being generated with @_expose(wasm "bjs_someFunctionName") rather than @_expose(wasm, "bjs_someFunctionName")#557
Closed
scottmarchant wants to merge 1 commit intoswiftwasm:mainfrom
Conversation
…_load")` rather than `@_expose(wasm, "bjs_load")`, which broke compilation for generated code.
Member
|
Thanks! But closing in favor of #555 🙏 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem summary
A recent BridgeJS change caused generated swift interfacing code to use
@_expose(wasm "bjs_someFunctionName"), rather than@_expose(wasm, "bjs_someFunctionName").This change adds back the command, which is required to compile.
Details
For the following code:
A recent change caused the following swift code to be generated:
This fails to compile with an error like the following:
Instead, the generated code needs to add a comma separator: