BridgeJS: Fix namespace enum with @JS(namespace:) attribute#562
Merged
kateinoigakukun merged 1 commit intoswiftwasm:mainfrom Feb 3, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug where namespace enums with explicit
@JS(namespace:)attribute generated incorrect Swift code that failed to compile.Issue
When using
@JS(namespace: "Services.Graph")on a namespace enum:The generated Swift code incorrectly used the JavaScript namespace path as the Swift call path:
Fix
Changed
StaticContext.namespaceEnumto carry the actual Swift type name (swiftCallName) instead of relying on the JavaScript namespace path.Now generates correct Swift code:
The JavaScript namespace organization is preserved separately and doesn't affect the Swift call site.
Testing
@JS(namespace:)attributeServices.Graph.GraphOperationsnamespaceUtils.StringUtils) which was missing