BridgeJS: Enforce throws(JSException) on @JS protocol methods#563
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 3, 2026
Merged
BridgeJS: Enforce throws(JSException) on @JS protocol methods#563krodak merged 1 commit intoswiftwasm:mainfrom
krodak merged 1 commit intoswiftwasm:mainfrom
Conversation
Member
|
I think we need to enable the exception check emitted by |
Member
Author
|
@kateinoigakukun my bad, now added exception checking for protocol wrapper methods with new The issue was that protocol wrappers call into JavaScript (like |
1c4d924 to
905f4ea
Compare
Member
There was a problem hiding this comment.
Could you remove this snapshot file? It's now moved under BridgeJSCodegenTests.
BridgeJS: Enforce throws(JSException) on @js protocol methods
905f4ea to
d4da0e3
Compare
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
throws(JSException)on@JS protocolmethods, matching the import side (@JSFunction) behaviorTest updates
Protocol.swifttest input: Addedthrows(JSException)to all protocol methodsExportAPITests.swift: UpdatedDataProcessorprotocol methods with throwsDocumentation
Exporting-Swift-Protocols.mdwith throws requirement and examplesMotivation
This partially addresses the inconsistency where
@JSFunction(import side) requiresthrows(JSException)but@JS protocolmethods (export side) didn't.Properties will be covered in separate PR 🙏🏻