BridgeJS: Add JSObject and @JSClass struct support for arrays and struct#566
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 3, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to array support PR - adds missing support for
JSObjectand@JSClass structelement types, to address: #543The implementation for these types already existed in the codebase (
@JSClass structmaps to.jsObjectinternally and shares the same code path), but it was not tested and was not entirely working, so this PR:Fix
JSObject arrays were incorrectly adding cleanup callbacks that released retained objects. This differed from:
For JSObjects, we retain the original object reference, not a temporary copy. Swift might return the same object, so cleanup would incorrectly release an object still in use. The fix removes cleanup for JSObject array elements, making them consistent with non-array JSObject handling.
Notes
Let me know if I missed something and we should extend support somehow, but I guess the other improvement would be to support import-side but this is separate issue.