feat(phase-2): implement file cleanup and fix warnings

codi-rs/docs/PRODUCTION_READINESS_PLAN.md

@@ -2,7 +2,7 @@
 
 **Objective:** Bring codi/codi-rs from 88% to 100% production readiness  
 **Timeline:** 2-3 weeks  
-**Branch:** `feat/production-readiness-phase-1`  
+**Current Branch:** `feat/production-readiness-phase-2`  
 **Priority:** Fix critical panics first, then polish
 
 ---
@@ -16,24 +16,24 @@ This plan addresses all production readiness issues identified in the assessment
 
 ---
 
-## Phase 1: Critical Issues (Week 1) - ELIMINATE PRODUCTION PANICS
+## Phase 1: Critical Issues (Week 1) - ELIMINATE PRODUCTION PANICS ✅ COMPLETE
 
-### 1.1 Priority Files (Fix First)
+### 1.1 Priority Files (Fixed)
 
 **File 1: `src/tui/app.rs:1683-1687`**
 - **Issue:** Two `panic!` calls in production app logic
-- **Fix:** Replace with proper error handling and user notification
-- **Lines:** 1683, 1687
+- **Fix:** Replaced with proper error handling and user notification
+- **Status:** ✅ Complete
 
 **File 2: `src/orchestrate/ipc/transport.rs:133-152`**
 - **Issue:** 9 `.expect()` calls in IPC transport layer
-- **Fix:** Convert to `Result` with descriptive errors
-- **Impact:** IPC failures crash the entire application
+- **Fix:** Converted to `Result` with descriptive errors
+- **Status:** ✅ Complete
 
 **File 3: `src/orchestrate/ipc/client.rs:347, 488`**
 - **Issue:** `.unwrap()` and `.expect()` in message handling
 - **Fix:** Graceful degradation on malformed messages
-- **Impact:** Worker communication failures
+- **Status:** ✅ Complete
 
 ### 1.2 Implementation Strategy
 
@@ -49,15 +49,15 @@ This plan addresses all production readiness issues identified in the assessment
 ```
 
 **Pattern:**
-1. Identify all panics/unwraps/expects (100 total)
-2. Replace with proper error types
-3. Add context with `tracing::error!`
-4. Ensure graceful degradation
-5. Test error paths
+1. ✅ Identify all panics/unwraps/expects (100 total)
+2. ✅ Replace with proper error types
+3. ✅ Add context with `tracing::error!`
+4. ✅ Ensure graceful degradation
+5. ✅ Test error paths
 
 ### 1.3 Error Type Design
 
-Add comprehensive error types to affected modules:
+Added comprehensive error types to affected modules:
 
 ```rust
 // src/orchestrate/ipc/error.rs
@@ -79,35 +79,71 @@ pub enum IpcError {
     HandshakeFailed(String),
     #[error("Permission request failed: {0}")]
     PermissionFailed(String),
+    #[error("Worker not connected: {0}")]
+    WorkerNotConnected(String),
+    #[error("Invalid handshake")]
+    InvalidHandshake,
+    #[error("Channel closed")]
+    ChannelClosed,
+    #[error("Server not started")]
+    NotStarted,
+    #[error("Invalid message: {0}")]
+    InvalidMessage(String),
+    #[error("Serialization error: {0}")]
+    Serialization(String),
 }
 ```
 
-### 1.4 Acceptance Criteria
+### 1.4 Files Modified in Phase 1
 
-- [ ] Zero `panic!` calls in production code (tests OK)
-- [ ] Zero `expect()` calls in production code
-- [ ] Zero `unwrap()` calls in production code paths
-- [ ] All errors properly propagated with context
-- [ ] No behavioral regressions
+- `src/orchestrate/ipc/error.rs` (NEW - comprehensive error type)
+- `src/orchestrate/ipc/mod.rs` (exports)
+- `src/orchestrate/ipc/client.rs` (fixed unwraps, added InvalidMessage)
+- `src/orchestrate/ipc/server.rs` (uses unified IpcError)
+- `src/orchestrate/commander.rs` (fixed socket path handling)
+- `src/orchestrate/worktree.rs` (fixed 3 unwraps)
+- `src/orchestrate/griptree.rs` (fixed 4 unwraps)
+- `src/tui/terminal_ui.rs` (removed unused import)
+
+### 1.5 Acceptance Criteria
+
+- [x] Zero `panic!` calls in production code (tests OK)
+- [x] Zero `expect()` calls in production code
+- [x] Zero `unwrap()` calls in production code paths
+- [x] All errors properly propagated with context
+- [x] No behavioral regressions
+- [x] All 516 tests pass
 
 ---
 
-## Phase 2: Code Quality (Week 1-2)
+## Phase 2: Code Quality (Week 1-2) - IN PROGRESS
 
 ### 2.1 Clean Up Warnings
 
 **Issues:**
-- Unused import `Stylize` in `src/tui/terminal_ui.rs:18`
-- Unused function `load_session` in `src/main.rs:505`
+- ~~Unused import `Stylize` in `src/tui/terminal_ui.rs:18`~~ ✅ Fixed via cargo fix
+- ~~Unused function `load_session` in `src/main.rs:505`~~ ✅ Removed
 
-**Action:** Remove or implement
+**Status:** Clean build with zero warnings ✅
 
 ### 2.2 Address TODOs by Priority
 
 **HIGH (Complete in Phase 2):**
-1. `src/symbol_index/indexer.rs:561` - File cleanup for deleted/renamed files
-2. `src/symbol_index/service.rs:206, 229` - Usage detection & dependency graph
-3. `src/tui/syntax/highlighter.rs:49` - Tree-sitter-markdown compatibility
+
+1. **`src/symbol_index/indexer.rs:561` - File cleanup for deleted/renamed files**
+   - **Status:** ✅ IMPLEMENTED
+   - **Changes:**
+     - Added `get_all_files()` method to `SymbolDatabase`
+     - Implemented `cleanup_deleted()` to remove stale entries
+     - Files are checked against disk and deleted from DB if missing
+
+2. **`src/symbol_index/service.rs:206` - Usage detection**
+   - **Status:** 🔄 IN PROGRESS
+   - **Description:** Find where symbols are used across the codebase
+
+3. **`src/symbol_index/service.rs:229` - Dependency graph**
+   - **Status:** 🔄 IN PROGRESS
+   - **Description:** Build file dependency graph from imports
 
 **LOW (Defer to Phase 4):**
 - `src/tui/app.rs:1355` - Worktree listing exposure
@@ -211,29 +247,29 @@ async fn test_ipc_bind_failure() {
 
 ## Success Criteria
 
-### Phase 1 (Critical) ✅
-- [ ] Zero `panic!` in production code
-- [ ] Zero `expect()` in production code
-- [ ] Zero `unwrap()` in production code paths
-- [ ] All IPC errors handled gracefully
-- [ ] Comprehensive error types implemented
+### Phase 1 (Critical) ✅ COMPLETE
+- [x] Zero `panic!` in production code
+- [x] Zero `expect()` in production code
+- [x] Zero `unwrap()` in production code paths
+- [x] All IPC errors handled gracefully
+- [x] Comprehensive error types implemented
 
-### Phase 2 (Quality) ✅
-- [ ] Clean build with zero warnings
+### Phase 2 (Quality) 🔄 IN PROGRESS
+- [x] Clean build with zero warnings
 - [ ] High-priority TODOs resolved
 - [ ] Remaining TODOs documented in GitHub issues
 
-### Phase 3 (Testing) ✅
+### Phase 3 (Testing) ⏳ PENDING
 - [ ] Error path coverage >80%
 - [ ] Performance benchmarks established
 - [ ] Performance budgets defined
 
-### Phase 4 (Docs) ✅
+### Phase 4 (Docs) ⏳ PENDING
 - [ ] Deployment guide complete
 - [ ] Security audit passed
 - [ ] Configuration reference complete
 
-### Phase 5 (Monitoring) ✅
+### Phase 5 (Monitoring) ⏳ PENDING
 - [ ] Health check implemented
 - [ ] Metrics collection comprehensive
 - [ ] Production-ready telemetry
@@ -242,30 +278,22 @@ async fn test_ipc_bind_failure() {
 
 ## Implementation Log
 
-### Day 1: Setup & Priority Files
-- [ ] Create error types for IPC layer
-- [ ] Fix `src/orchestrate/ipc/transport.rs`
-- [ ] Fix `src/orchestrate/ipc/client.rs`
-
-### Day 2: TUI & App Layer
-- [ ] Fix `src/tui/app.rs` panics
-- [ ] Fix remaining IPC unwraps
-- [ ] Add error context with tracing
-
-### Day 3: Remaining Unwraps
-- [ ] Audit all 100 unwrap/panic locations
-- [ ] Fix remaining production code issues
-- [ ] Verify tests still pass
-
-### Day 4: Testing & Validation
-- [ ] Add error path tests
-- [ ] Run full test suite
-- [ ] Performance sanity check
-
-### Day 5: Documentation & Cleanup
-- [ ] Update docs
-- [ ] Create GitHub issues for TODOs
-- [ ] Final review
+### Phase 1: Production Panics (COMPLETE)
+- **Date:** 2026-02-07
+- **Branch:** feat/production-readiness-phase-1
+- **PR:** #284
+- **Commits:** 5
+- **Files Changed:** 9 (+473/-43 lines)
+- **Tests:** All 516 passing
+
+### Phase 2: Code Quality (IN PROGRESS)
+- **Date:** 2026-02-07
+- **Branch:** feat/production-readiness-phase-2
+- **Completed:**
+  - ✅ Fixed unused function warning in main.rs
+  - ✅ Implemented file cleanup in symbol_index
+  - 🔄 Implementing usage detection
+  - 🔄 Implementing dependency graph
 
 ---
 
@@ -281,4 +309,4 @@ async fn test_ipc_bind_failure() {
 
 **Last Updated:** 2026-02-07  
 **Author:** Codi AI Assistant  
-**Branch:** feat/production-readiness-phase-1
+**Current Branch:** feat/production-readiness-phase-2

codi-rs/src/main.rs

@@ -12,7 +12,7 @@ use codi::agent::AgentConfig;
 use codi::config::{self, CliOptions};
 use codi::providers::{create_provider_from_config, ProviderType};
 use codi::tools::ToolRegistry;
-use codi::tui::{App, build_system_prompt_from_config};
+use codi::tui::build_system_prompt_from_config;
 use codi::tui::terminal_ui::run_terminal_repl;
 
 /// Codi version string.
@@ -501,11 +501,3 @@ async fn run_repl(config: &config::ResolvedConfig, auto_approve: bool, verbose:
     let debug_mode = verbose || std::env::var("CODI_DEBUG").is_ok();
     run_terminal_repl(config, auto_approve, debug_mode).await
 }
-
-async fn load_session(app: &mut App, session_name: &str) -> anyhow::Result<()> {
-    // Try to load by exact name first, then by fuzzy match
-    if let Err(_) = app.load_session(session_name).await {
-        return Err(anyhow::anyhow!("Session not found: {}", session_name));
-    }
-    Ok(())
-}