Split out of a review comment on #1310 (#1310 (comment)).
An LNURL-pay invoice, or any invoice carrying an h tag, is stored with the description hash hex as its activity message: processBolt11 creates the row with message = kind.description.orEmpty() (CoreService.kt:804) and ldk-node fills description with the hash hex for Bolt11InvoiceDescriptionRef::Hash.
The hex is user-visible:
ActivityRow.kt:138 renders message.ifEmpty { time }, so the Home row subtitle shows a 64-character hex string instead of the time.ActivityDetailScreen.kt:558 renders any non-empty message as the "Invoice note", so the detail screen shows the same hex as if the payee had written it.
This is pre-existing on master. #1310 (LNURL-pay comment as activity note) only replaces the string when a pending comment exists, so an LNURL payment sent with an empty comment still shows the hash.
Suggested fix
Store an empty message for description-hash invoices, so the row falls back to the time subtitle and the detail screen shows no note. Either have bitkit-core expose whether the invoice carries a description hash rather than a description, or treat a 64-character hex description that is not a direct description as "no description" in processBolt11.
Related to #1275
Split out of a review comment on #1310 (#1310 (comment)).
An LNURL-pay invoice, or any invoice carrying an
htag, is stored with the description hash hex as its activity message:processBolt11creates the row withmessage = kind.description.orEmpty()(CoreService.kt:804) and ldk-node fillsdescriptionwith the hash hex forBolt11InvoiceDescriptionRef::Hash.The hex is user-visible:
ActivityRow.kt:138rendersmessage.ifEmpty { time }, so the Home row subtitle shows a 64-character hex string instead of the time.ActivityDetailScreen.kt:558renders any non-empty message as the "Invoice note", so the detail screen shows the same hex as if the payee had written it.This is pre-existing on master. #1310 (LNURL-pay comment as activity note) only replaces the string when a pending comment exists, so an LNURL payment sent with an empty comment still shows the hash.
Suggested fix
Store an empty message for description-hash invoices, so the row falls back to the time subtitle and the detail screen shows no note. Either have bitkit-core expose whether the invoice carries a description hash rather than a description, or treat a 64-character hex
descriptionthat is not a direct description as "no description" inprocessBolt11.Related to #1275