Skip to content

chore: add just launcher#962

Open
ovitrif wants to merge 1 commit into
masterfrom
chore/add-just
Open

chore: add just launcher#962
ovitrif wants to merge 1 commit into
masterfrom
chore/add-just

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented May 21, 2026

This PR adds a Just command launcher for common local Android development tasks.

Description

This PR:

  1. Adds a top-level Justfile with short commands for setup, build, test, lint, just run, release, E2E, translations, changelog preview, and cleanup.
  2. Adds an .env.example template and just init for creating the ignored local .env file.
  3. Updates README, agent rules and release command docs to route thru the Just launcher.
  4. Hardens translation pull cleanup so pulled XML markup is fixed and malformed XML fails fast.

Preview

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • just init
  • just list
  • just --dry-run run
  • just --dry-run release
  • just --dry-run test file LightningRepoTest
  • just --dry-run test lane ComposeUi
  • just --dry-run translations pull
  • just --dry-run translations push source
  • just --dry-run translations push all
  • just --dry-run translations push exits with usage
  • Fresh temp worktree: just translations pull
  • Fresh temp worktree: parsed all pulled values*/strings.xml files with Python XML parser
  • Fresh temp worktree with stubbed tx: just translations push source and just translations push all
  • Fresh temp worktree with stubbed tx: bare just translations push exits with usage
  • just --dry-run e2e network assembleTnetRelease
  • just --dry-run e2e no geo
  • just compile
  • just test
  • just lint
  • just build
  • Just 1.51.0 formatter: just --unstable --fmt --check

chatgpt-codex-connector[bot]

This comment was marked as resolved.

@ovitrif ovitrif added this to the 2.4.0 milestone May 22, 2026
@ovitrif ovitrif self-assigned this May 22, 2026
@ovitrif ovitrif requested review from ben-kaufman and jvsena42 May 22, 2026 00:23
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1c0320df4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Justfile Outdated
@ovitrif ovitrif changed the title chore: add just launcher chore: setup just launcher commands May 22, 2026
@ovitrif ovitrif changed the title chore: setup just launcher commands chore: add just launcher commands May 22, 2026
Comment thread Justfile Outdated
Comment thread Justfile
Comment thread .env.example Outdated
Comment thread .env.example Outdated
Comment thread README.md
@ovitrif ovitrif requested review from ben-kaufman and jvsena42 May 23, 2026 03:05
Comment thread Justfile Outdated
@ovitrif ovitrif requested a review from ben-kaufman May 25, 2026 14:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d317acecb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Justfile
@ovitrif ovitrif changed the title chore: add just launcher commands chore: add just launcher May 25, 2026
chatgpt-codex-connector[bot]

This comment was marked as resolved.

ben-kaufman
ben-kaufman previously approved these changes May 25, 2026
Copy link
Copy Markdown
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 25, 2026

Looks good to me.

Thanks 🙏🏻

I'm not certain the translation commands work at all. Last time I checked them they didn't work (test on fresh clone), and IIRC Phil also signalled they didn't work for him.
So my plan is do a round of local runs of these commands manually and still iterate as needed, hope I can squeeze a fix for those in here as well as needed 🤞

@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 25, 2026

Checked this from a fresh temp worktree.

Results:

  • just translations pull reaches Transifex and completes, but currently pulls content changes for values-b+es+419, values-es-rES, and values-pt-rBR.
  • The pull exposed a real pre-existing issue: Transifex can return half-escaped markup like <accent&gt;, which made pulled XML malformed.
  • Fixed the pull cleanup to repair that markup before validation and to fail if any pulled strings.xml remains malformed.
  • Verified all pulled values*/strings.xml files parse after the fix.
  • Verified just translations push and just translations push source with a stubbed tx so the local rename/restore workflow is tested without mutating Transifex.

Updated in and force-pushed.

@ovitrif ovitrif requested a review from ben-kaufman May 25, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants