feat: add trezor onchain event watcher#976
Open
coreyphillips wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4fd96a304
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Event Watcher section to the (dev-only) Trezor screen that consumes the new bitkit-core on-chain xpub watcher. Enter or populate an extended key, start/stop a live watcher, and observe streaming balance, transactions, connection status, and an event log.
Depends on bitkit-core
0.1.65Description
WatcherSectioncomposable: extended-key + gap-limit inputs, populate-from-xpub, start/stop controls, and a live view of balance, transactions, connection status, and an event log.TrezorViewModel:WatcherEvents from the repo and maps them into a newTrezorWatcherState(balance, transactions, tx count, block height, account type, connection status, event log).watcherId, validates the xpub/gap-limit inputs, and surfaces errors via toasts.onCleared()so no watcher thread is leaked.TrezorRepo: exposes a bufferedwatcherEventsSharedFlowbridged from a coreEventListener, plusstartWatcher/stopWatcher/stopAllWatchersreturningResult<Unit>.TrezorService: thin wrappers overonchainStartWatcher/onchainStopWatcher/onchainStopAllWatchers.bitkit-coreto0.1.65inlibs.versions.toml.QA Notes
0.1.65.onCleared)../gradlew compileDevDebugKotlin,./gradlew testDevDebugUnitTest --tests TrezorViewModelTest --tests TrezorRepoTest,./gradlew detekt— all pass.