Add tests and fix for mdns NameSliceIter next_back - #104
Open
mlandauer wants to merge 1 commit into
Open
Conversation
The backwards labels iterator for NameSlice would always return None. This adds some tests for the forward and backwards iterator that would fail with the current implementation. To fix the issue I added a second index for tracking the backwards iterator seperate from the forward iterator. The docs for DoubleEndedIterator says "It is important to note that both back and forth work on the same range, and do not cross: iteration is over when they meet in the middle." Then a small bit of refactoring to extract common code from the back and next_back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backwards labels iterator for NameSlice would always return None. This adds some tests for the forward and backwards iterator that would fail with the current implementation.
To fix the issue I added a second index for tracking the backwards iterator seperate from the forward iterator.
The docs for DoubleEndedIterator says
"It is important to note that both back and forth work on the same range, and do not cross: iteration is over when they meet in the middle."
Then a small bit of refactoring to extract common code from the back and next_back.