Conversation
Refine GitHub Actions workflows: - Merge coding-style and static-analysis into a single lint job - Add actions/cache for apt packages with workflow-hash keys - Drop redundant build-essential install from unit-tests - Add missing checkout step to build-lkl.yml build job - Remove scripts/ from build artifact (integration-tests checks out) Extract duplicated shell helpers into scripts/common.sh: - die(), detect_arch(), download_file(), verify_sha256(), find_timeout_cmd() - Make set_colors() portable (replace [[ ]] with [ ]) - Use absolute-path sourcing pattern across all scripts Change-Id: Ib44af8ca4fe14982b45464476386efbb9afe3423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine GitHub Actions workflows:
Extract duplicated shell helpers into scripts/common.sh:
Change-Id: Ib44af8ca4fe14982b45464476386efbb9afe3423
Summary by cubic
Merged style and static analysis into a single CI lint job, added apt caching, and extracted shared shell helpers into
scripts/common.shto reduce duplication and improve portability. CI runs faster and fetch/build scripts are more reliable.Refactors
lintjob.actions/cachewith workflow-hash keys.scripts/common.sh(die, detect_arch, download_file, verify_sha256, find_timeout_cmd) with absolute-path sourcing and POSIX-friendlyset_colors().scripts/common.sh.Bug Fixes
actions/checkoutin the LKL build workflow.build-lkl.shreliably checkout branches/tags and bare commit SHAs (handles shallow clones).build-essentialinstall from unit-tests; only install needed packages.scripts/from build artifacts; integration job checks out sources directly.Written for commit 00005f1. Summary will update on new commits.