particleos: add support for sysinstall#158
Merged
Merged
Conversation
poettering
force-pushed
the
syinstall
branch
2 times, most recently
from
ee20e04 to
e7e1f54
Compare
Member
Author
|
this new version of the PR gets rid of /usr/lib/repart.sysinstall.d/ again, as per discussion with @daandemeyer offline. The same repart.d definitions are now used when booting regularly to extend the root disk, and when doing sysinstall onto a new disk |
daandemeyer
approved these changes
May 11, 2026
Collaborator
daandemeyer
left a comment
daandemeyer
left a comment
There was a problem hiding this comment.
Fix the commit messages as well please, they're out of date
This adds a new UKI profile for booting in installer mode, using the recently merged sysinstall feature of systemd: systemd/systemd#41877 This also changes the live mode (which is very similar) to not disable firstboot, but instead uses credentials to tweak the prompts. This is beneficial, since we want firstboot to run always, not because of the interactivity features, but simply because it processes a bunch of firstboot.* credentials we want. It also gets rid of the changes made to console logging. That's useful for the debug boot mode, but is inappropriate for the installer and live profiles which should just be "clean" This drops CopyFiles= from the installed repart.d/ drop-in for the ESP: we don't need it anymore, systemd-sysinstall's "bootctl link" and "bootctl install" invocations are much better at setting up the ESP.
Since libfdisk became a dlopen() dependency we are missing it in the fedora initrd, because it doesn't get pull in by anything else but repart.
…aw systemd-repart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new UKI profile for booting in installer mode, using the recently merged sysinstall feature of systemd:
systemd/systemd#41877
This also changes the live mode (which is very similar) to not disable firstboot, but instead uses credentials to tweak the prompts. This is beneficial, since we want firstboot to run always, not because of the interactivity features, but simply because it processes a bunch of firstboot.* credentials we want.
It also gets rid of the changes made to console logging. That's useful for the debug boot mode, but is inappropriate for the installer and live profiles which should just be "clean"
This makes usr/lib/repart.sysinstall.d/ almost identical to the regular /usr/lib/repart.d/ with one exception: the CopyFiles= line is dropped now, because we don't need it in the installer case (because sysinstall utilizes bootctl link + bootctl install to initialize the ESP properly). Eventually we probably should drop CopyFiles= entirely, but after discussing with Daan this day is not today yet.