docs: record open-issue triage verdicts (#3-#9) - #17
Closed
systemfsoftware-maker wants to merge 2 commits into
Closed
docs: record open-issue triage verdicts (#3-#9)#17systemfsoftware-maker wants to merge 2 commits into
systemfsoftware-maker wants to merge 2 commits into
Conversation
Four-reviewer doc review falsified the two planned closures: - #4 non-issue repudiated: launcher BinaryNotFound path is live (npm/packages/comment-checker/src/index.ts getBinaryPath); platform manifests ship files:[entry.bin] - #9 stays open: no workflow YAML/expression validation anywhere - #8 mechanism corrected: check-matrix gate fails loudly (probe: flow-style release.yml -> FAIL per target, exit 1), not vacuous All seven issues remain open; verdict doc records corrected mechanisms and severities. No GitHub issue mutation runs.
Code review (correctness + project-standards, validator-confirmed) found: - #7: the .sha256 sidecar the cross-check reads has no producer at HEAD (writer removed in e92d150); the guard is inoperative, so #7 keeps filed P1 instead of the first-draft P3 correction. - plan/record: ci.yml npm job gates list four checks, not two; none parses workflow YAML. Verdict record and plan are re-anchored to the current tree; no issue mutation is performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Durable verdict record for the seven open issues (#3-#9, residual findings
from PR #10), plus the revised triage plan. A four-reviewer doc review
falsified the first plan draft's two planned closures, so the record keeps
all seven open with corrected mechanisms.
Verdicts
Key corrections: #4 launcher BinaryNotFound path is live (platform
packages ship the binary); #8 check-matrix fails loudly, not vacuously;
#7's sha sidecar has no producer at HEAD (writer removed e92d150) so the
cross-check guard is non-functional; #9 corrected framing (real exposure on
the only publish path).
Evidence
docs/residual-review-findings/185fa9144.md— per-issue verdicts withfile/line evidence and correction history
docs/plans/2026-08-21-001-docs-open-issue-triage-verdict-plan.md—sources, adjudication, KTDs, DoD, verification contract
Safety
actionable findings validated by an independent validator batch and
committed as 6916144
Closes nothing. Re-opens nothing.