chore: flake update, CI cache and VM storage fixes#10
Merged
Conversation
📝 WalkthroughWalkthroughThis PR migrates CRI storage to an ext4-backed sparse image and updates the runner, module, and docs accordingly. It also adds Cachix/Nix installer workflow settings and pins the update-flake-lock action version. ChangesCRI Storage Migration
CI/Release Workflow Updates
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@flake.nix`:
- Line 111: The CRI storage backing file is currently placed inside $AGENT_DIR,
which is also exported into the guest by the agent-home virtiofs share. Move the
cri-storage.img path in the setup around the CRI_IMG assignment to a host-only
sibling/state directory outside the shared agent home, and update any related
README path references so the guest cannot see or modify the raw image.
- Line 231: The sed substitution that uses $CRI_IMG needs escaping before it is
inserted into the replacement text, since symbols like &, \, or | can corrupt
the generated command. Update the logic around the CRI image replacement in the
flake.nix sed command to sanitize the value of $CRI_IMG before passing it to
sed, so the runner command is built safely even when AGENT_DIR contains special
characters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3a279de4-001c-4639-bb46-95c5aae10d78
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/workflows/ci.yml.github/workflows/release.yml.github/workflows/update-flake.ymlREADME.mdflake.nixmodules/cri.nix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
/var/lib/containers, improving runtime reliability.