Refactor connection timeout and connection admission; reduce idle timeout#33
Merged
Conversation
…eout Remove HttpServer.can_handle_new_client() responsible for evicting stale/inactive connections. Idle connection timeout is already part of the HTTP connection handling logic (see also HttpConnection.RECV_TIMEOUT_SECONDS). Instead, use the availibility of the buffer pool as the admission control mechanism, and wait for each connection to reserve a sender and receiver buffer pair. Make BaseConnection.close() idempontent, and allow the close method to be called multiple times during error handling for example. In such cases, BaseConnection.close() returns immediately instead of rerunning cleanup steps. Reduce idle timeout from 10 seconds to 3 seconds. This allows other clients to wait less for available stream buffers. Additional changes: - move client removal to the end of the finally branch - remove HttpServer._drop_client() and make it inline, as it is only referenced in one place - update description of class variables in HttpConnection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
HttpServer.can_handle_new_client()responsible for evicting stale/inactive connections. Idle connection timeout is already part of the HTTP connection handling logic (see alsoHttpConnection.RECV_TIMEOUT_SECONDS).Instead, use the availibility of the buffer pool as the admission control mechanism, and wait for each connection to reserve a sender and receiver buffer pair.
Make
BaseConnection.close()idempontent, and allow the close method to be called multiple times during error handling for example. In such cases,BaseConnection.close()returns immediately instead of rerunning cleanup steps.Reduce idle timeout from 10 seconds to 3 seconds.
This allows other clients to wait less for available stream buffers.
Additional changes:
HttpServer._drop_client()and make it inline, as it is only referenced in one placeHttpConnection