Open
Conversation
naoto-iwase
reviewed
Nov 28, 2025
Comment on lines
+29
to
+34
| if nums.is_empty() { | ||
| return 0; | ||
| } | ||
| if nums.len() == 1 { | ||
| return nums[0]; | ||
| } |
There was a problem hiding this comment.
エッジケースの処理、こう書いてみてもいいかもしれません。
match nums.len() {
0 => return 0,
1 => return nums[0],
_ => {}
}| }; | ||
|
|
||
| let with_first_max_amount = collect_max_amount(&nums[0..nums.len() - 1]); | ||
| let with_out_first_max_amount = collect_max_amount(&nums[1..nums.len()]); |
There was a problem hiding this comment.
細かいですが、withoutで一語なのでwith_outの部分はつなげたいですね。
|
読みやすいコードでした。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題: 213. House Robber II
次に解く問題: 121. Best Time to Buy and Sell Stock
ファイルの構成:
./src/bin/<各ステップ>.rs