Open
Conversation
ronishefi9
force-pushed
the
taboola-support-native
branch
from
ca4cb04 to
89556d2
Compare
ronishefi9
force-pushed
the
taboola-support-native
branch
from
43f3b07 to
fef5d0b
Compare
…g banner support. Added and updated tests.
…g banner support. Added and updated tests.
ronishefi9
force-pushed
the
taboola-support-native
branch
from
fef5d0b to
15ad62f
Compare
Pull Request Test Coverage Report for Build 21592354964Details
💛 - Coveralls |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…id#14399) * Fix slot name detection to use best practices * Post review commit * Linter fix * Last post review commit List of concerned names managed | adUnitCode | Résultat | | ---------------------------------- | ---------------- | | `div-gpt-ad-article_top_123456` | `article_top` | | `div-gpt-ad-sidebar-1678459238475` | `sidebar` | | `div-gpt-ad-topbanner-1` | `topbanner-1` ✅ | | `div-gpt-ad-topbanner-2` | `topbanner-2` ✅ | | `sidebar-123456` | `sidebar-123456` | | `article_bottom` | `article_bottom` | * Only normalize GPT codes, leave others unchanged * Add tests on FIX and missing code coverage
… activity checks to get stuck in an infinite loop (prebid#14366) * realTimeData: fix bug where setting circular references in FPD causes activity checks to get stuck in an infinite loop * handle circular references in unguarded properties * prefer allowing more data over avoiding leaks * more edge cases
Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Core: loading external scripts linting rule * using default rule instead of custom * fixing overwritten event/adLoader rule * change to no-restricted-syntax * no-restricted-imports --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* SBE-2291 Remove protected audience related test code * SBE-2291 Remove protected audience related code
…ity tracking logic (prebid#14372) * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic * bidmaticBidAdapter: update viewability tracking logic
…handling (prebid#14362) * - Migrated to TypeScript - Removed hardcoded token injection into ortb2Fragments and delegate to the HUMAN implementation, enabling management of which bidders receive tokens and enhancing monitoring and control of latency and performance - Introduce a cached implementation reference via getImpl() - Add module version query parameter when loading the implementation script - Wire onAuctionInitEvent so the implementation can collect QoS, telemetry and statistics per auction * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * - validate module version parameter in script URL - add HumanSecurityImpl interface --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* WURFL RTD: update module documentation * WURFL RTD: update module documentation
* Page view ID. * Page view ID. * Removed console.log. * Removed unused import. * Improved example. * Fixed some tests. * Kobler bid adapter: pass adunitcode in bid request.
…side friendly iframes (prebid#14414) * percentInView: fix bug where viewability calculation is inaccurate inside friendly iframes * use boundingClientRect
* initial commit * storeSplits method * unit tests * remove test * removing storing & extract merging ortb2 * lint * adding default handling * lint * merge fpd cache * review fixes * refactoring, bug fixing, tests * lint * extending bidPrice schema function * removing invalid example * session random * rename * module name * random per auction * modifies some schema function to return value instead of condition result * extra schema evaluators * json fix * evaluating rules per auction * evaluating rules per auction * static config * auctionId * safe guards * registering activities only once * expose configuration type; update integ example rules json URL * evaluating rules fix * fixing model group selection --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
- Added email address to the main description - Added 'cur' parameter to the parameters list - Minor changes in the Adunit config examples
* TeqBlazeSalesAgent Bid Adapter: initial release * update doc --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Anna Yablonsky <annay+perion@perion.com>
* adding new adapter for Admination * remove alias for adnimation form limelightDigital following new partnership --------- Co-authored-by: Anna Yablonsky <annay+perion@perion.com>
…prebid#14515) * TeqBlazeSalesAgent Bid Adapter: initial release * update doc * fix for uspConsent string in getUserSyncs * fix test --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* ADJS-1646-update-userId-handling * added test: should filter pubProvidedId entries by allowed sources * support ortb2.user.ext.eids fallback and add identity parity tests * Prioritize prebid.js 10 structure * GumGum Adapter: fix TDID extraction across all EID uids and add edge-case tests
* mediafuseBidAdapter Updates and Refactor * Addressed Flagged Issues and removed ADPOD import. * More Fixes * bug fixes, code quality improvements, and expanded test coverage * Updates and Fixes * Flagged Issues Fixes
…rebid#14529) This reverts commit 192f96a.
* Add user sync and reporting urls * add tests, minor refactor * add window.addEventListener only once * fix JSON.parse can return null * Fix unconditional setting user.ext.uids * Add test * swap uids from storage and original user.ext.uids * Add keepalive and log only when debug is turned on --------- Co-authored-by: Michal Kváček <michal.kvacek@performax.cz>
…4429)" (prebid#14532) This reverts commit d8fb435.
Bumps [browserstack-local](https://github.com/browserstack/browserstack-local-nodejs) from 1.5.5 to 1.5.11. - [Release notes](https://github.com/browserstack/browserstack-local-nodejs/releases) - [Commits](browserstack/browserstack-local-nodejs@v1.5.5...v1.5.11) --- updated-dependencies: - dependency-name: browserstack-local dependency-version: 1.5.11 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.3.6 to 5.4.1. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.3.6...v5.4.1) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add pubstackBidAdapter (#1) * feat: add SparkBidAdapter * fix: reviews * fix: use iframe for user_sync * fix: change adapter name * fix: add test file * feat: add viewport value in imp[].ext.prebid.bidder.pubstack.vpl * fix: remove unused context * Pubstack Adapter: update utils and align adapter tests * Pubstack Bid Adapter: apply lint-driven TypeScript cleanups --------- Co-authored-by: gpolaert <gpolaert@pubstack.io> * Update modules/pubstackBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/pubstackBidAdapter.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update libraries/pubstackUtils/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/pubstackBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Pubstack Adapter: use placementPositionInfo telemetry --------- Co-authored-by: Stéphane Deluce <boluge@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v7...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ult behavior in prebid
… request payload, and optimizes deprecated navigator.platform (prebid#14538) * notify server if the page is secure * remove undefined initial * MediaGo Bid Adapter: update adapter, test page and spec Made-with: Cursor * MediaGo: remove redundant debug-info, use Network tab for verification; remove Chinese comments Made-with: Cursor --------- Co-authored-by: fangsimin@baidu.com <fangsimin@baidu.com> Co-authored-by: 方思敏 <fangsimin@fangsimindeMacBook-Pro.local>
…14544) * Screencore prebid adapter * rearrange code * use lowercase screncore bidder code * fix tests * update tests * trigger CI * Screencore Bid Adapter: add endpointId parameter * Updated adapter to use teqblazeUtils library * Added endpointId parameter support in test parameters * Updated test specs to include endpointId validation * Screencore Bid Adapter: update sync URL to base domain Update SYNC_URL constant to use base domain. The getUserSyncs function from teqblazeUtils will append the appropriate path. * Screencore Bid Adapter: migrate to teqblazeUtils library - Update imports to use buildRequestsBase, interpretResponse, getUserSyncs, isBidRequestValid, and buildPlacementProcessingFunction from teqblazeUtils - Remove storage manager dependency (no longer needed) - Update isBidRequestValid to use placementId/endpointId params validation - Refactor buildRequests to use buildRequestsBase pattern - Rewrite test suite to match teqblazeUtils API: - Simplify test data structures - Update server response format (body as array) - Add tests for placementId/endpointId validation - Update getUserSyncs URL format expectations * fix(screencore): correct region routing and endpoint path - add US/ and Canada/ timezone prefixes to getRegionSubdomainSuffix() - fix endpoint path from /prebid to /pbjs - move AD_URL inside buildRequests to compute per request --------- Co-authored-by: Kostiantyn Karchevsky <kostiantyn.karchevsky@teqblaze.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Pavlo Samonin <pavlo.samonin@teqblaze.com>
…prebid#14535) * Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id * updated skins parameter for consistency * updated test for updated skins parameter * ADJS-1271-send-envelope-param-for-lexicon * ADJS-1646-update-userId-handling * added test: should filter pubProvidedId entries by allowed sources * support ortb2.user.ext.eids fallback and add identity parity tests * ADTS-616-send-app-site-content-object-from-prebid-to-ad-server * Prioritize prebid.js 10 structure * GumGum Adapter: fix TDID extraction across all EID uids and add edge-case tests * added itype parameter * updated access to channel and network objects --------- Co-authored-by: Lisa Benmore <lbenmore@gmail.com> Co-authored-by: John Bauzon <john.bauzon@gumgum.com> Co-authored-by: ahzgg <abel.herrera@gumgum.com> Co-authored-by: ahzgg <163184035+ahzgg@users.noreply.github.com>
Co-authored-by: mderevyanko <mderevyanko24@gmail.com>
…king Prebid for a GAM url (prebid#14557)
* spacings * fix mediafuse * Format import statement for consistency * Update pubstackBidAdapter.ts
…oola-support-native
…-taboola into taboola-support-native
…ype is based on the request context which is set per media type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Supporting native media type in addition to the existing banner support in Taboola adapter.
Other information