Refactoring for reducing number of queries#188
Merged
Conversation
renato2099
force-pushed
the
renato2099/small_refactoring
branch
from
fd3ef1b to
a5d1f11
Compare
renato2099
force-pushed
the
renato2099/small_refactoring
branch
from
195c2ee to
4fa503c
Compare
Collaborator
Author
|
I will add unit tests for the new two methods once we agree on the current refactoring. |
Member
|
Excellent @renato2099 lets go through this tomorrow. I think this can be merged in after the PR for #181 |
Member
|
I refactored the slack calls. Let's test out on Thursday. |
renato2099
force-pushed
the
renato2099/small_refactoring
branch
3 times, most recently
from
cf22b7d to
60ce181
Compare
renato2099
force-pushed
the
renato2099/small_refactoring
branch
from
60ce181 to
9bace4e
Compare
renato2099
force-pushed
the
renato2099/small_refactoring
branch
3 times, most recently
from
2f06368 to
5479eaf
Compare
renato2099
force-pushed
the
renato2099/small_refactoring
branch
from
5479eaf to
82dd848
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Collaborator
Author
|
Hey @lewismc I added a few unit tests I think we should merge this |
lewismc
approved these changes
Mar 29, 2023
Member
lewismc
left a comment
lewismc
left a comment
There was a problem hiding this comment.
+1 I have tested locally and all checks out. Tox tests pass for Python 3.9 and 3.10 locally and also the CI testing passes successfully. I will open a follow on ticket with something i noticed.
lewismc
added
tests
lewismc
pushed a commit
that referenced
this pull request
Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lewismc this is a small refactoring such that in a second stage we can reduce the number of queries when checking global variables, i..e, instead for 1 SQL query per global attribute we can try to have just a few queries instead.
Another advantage is that we can batch the slack messages related to the metadata processing.