Skip to content

930: Changed author size test#894

Merged
Arshadul-Monir merged 2 commits intomainfrom
930
Apr 11, 2026
Merged

930: Changed author size test#894
Arshadul-Monir merged 2 commits intomainfrom
930

Conversation

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator

@Arshadul-Monir Arshadul-Monir commented Apr 11, 2026

930

Description of changes

Since practice PR was done to add new codebloom members to the credits, change the assertion in ApiControllerTest to check if authors.size() > 0 rather than strictly 6

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

@github-actions
Copy link
Copy Markdown
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

github-actions[bot]
github-actions bot previously approved these changes Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Title

930: Changed author size test


PR Type

Tests


Description

  • Update author list size assertion

  • Accommodate dynamic member additions


File Walkthrough

Relevant files
Tests
ApiControllerTest.java
Update author list size assertion in API controller test 

src/test/java/org/patinanetwork/codebloom/api/ApiControllerTest.java

  • Modified the assertion for the authors list size.
  • Changed the expected size from authors.size() == 6 to authors.size() >
    0.
  • This change accommodates the dynamic addition of new Codebloom members
    to the credits.
+1/-1     

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator Author

/deploy

@github-actions
Copy link
Copy Markdown
Contributor

Title

930: Changed author size test


PR Type

Bug fix, Enhancement


Description

  • Update API controller test for author count.

  • Disable rate limiting filter in CI profile.


File Walkthrough

Relevant files
Configuration changes
RateLimitingFilter.java
Disable Rate Limiting Filter in CI Profile                             

src/main/java/org/patinanetwork/codebloom/utilities/RateLimitingFilter.java

  • Added @Profile("!ci") annotation to the RateLimitingFilter class.
  • Disables the rate limiting filter when the ci Spring profile is
    active.
  • Prevents rate limiting from interfering with continuous integration
    tests.
+2/-0     
Tests
ApiControllerTest.java
Update API Controller Test for Author Count                           

src/test/java/org/patinanetwork/codebloom/api/ApiControllerTest.java

  • Modified the assertion for the authors list size.
  • Changed the check from authors.size() == 6 to authors.size() > 0.
  • Makes the test more robust to changes in the number of authors.
+1/-1     

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator Author

/deploy

@Arshadul-Monir Arshadul-Monir merged commit ef6b588 into main Apr 11, 2026
65 of 69 checks passed
@Arshadul-Monir Arshadul-Monir deleted the 930 branch April 11, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant