perf(sync): batch file uploads into single HTTP requests per batch#2985
Open
tusharmath wants to merge 2 commits intomainfrom
Open
perf(sync): batch file uploads into single HTTP requests per batch#2985tusharmath wants to merge 2 commits intomainfrom
tusharmath wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace per-file streaming uploads with batched HTTP requests to reduce server round-trips and improve sync throughput.
Context
The previous implementation used
futures::stream::iter(...).buffer_unordered(batch_size)to upload each file in its own HTTP request, with up tobatch_sizerequests in-flight concurrently. While this bounded memory, it meantNfiles producedNHTTP requests, creating significant overhead for large workspaces. Streaming parallelism also made progress tracking and error handling more complex.Changes
buffer_unorderedparallel streaming withchunks(batch_size).then(...)sequential batchingbatch_sizefiles is now collected into a singleFileUploadpayload and sent in one HTTP requestposthog-rsdependency to a newer revisionKey Implementation Details
The upload stream is now pinned (
Box::pin) since thethencombinator returns animpl Streamrather than the previously inferred concrete stream type. Peak memory usage remains bounded tobatch_size × avg_file_size— identical to before — but the number of HTTP requests drops fromNtoceil(N / batch_size).Use Cases
Testing