Skip to content

fix(command-list): include custom commands in plain output and deduplicate API fetch #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmath merged 3 commits into from
Apr 14, 2026
Merged

fix(command-list): include custom commands in plain output and deduplicate API fetch #3010

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0cfd37
fix(command-list): include custom commands in non-porcelain list output
tusharmath Apr 14, 2026
512ad7c
refactor(command-list): hoist get_commands call to avoid duplicate ap…
tusharmath Apr 14, 2026
18acde4
Merge branch 'main' into command-list-bug
tusharmath Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/forge_main/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,6 +1321,9 @@ impl<A: API + ConsoleWriter + 'static, F: Fn(ForgeConfig) -> A + Send + Sync> UI

/// Lists all the commands
async fn on_show_commands(&mut self, porcelain: bool) -> anyhow::Result<()> {
// Fetch custom commands once — used by both the porcelain and plain paths.
let custom_commands = self.api.get_commands().await?;

if porcelain {
// Build the full info with type/description columns for porcelain
// (used by the shell plugin for tab completion).
Expand Down Expand Up @@ -1365,7 +1368,6 @@ impl<A: API + ConsoleWriter + 'static, F: Fn(ForgeConfig) -> A + Send + Sync> UI
.add_key_value("description", title);
}

let custom_commands = self.api.get_commands().await?;
for command in custom_commands {
info = info
.add_title(command.name.clone())
Expand All @@ -1390,6 +1392,7 @@ impl<A: API + ConsoleWriter + 'static, F: Fn(ForgeConfig) -> A + Send + Sync> UI
} else {
// Non-porcelain: render in the same flat format as :help in the REPL.
let command_manager = ForgeCommandManager::default();
command_manager.register_all(custom_commands);
let info = Info::from(&command_manager);
self.writeln(info)?;
}
Expand Down
Loading